fix fermi_hubbard/publication_test by updating datadryad download URLs since they appear to have changed #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and QubitMapping data structures, and implement the swap update algorithm
…UpdateTransformer
…nd add test coverage for previously untested public functions
rmlarose
reviewed
Apr 27, 2021
Comment on lines
+244
to
+247
| "gaussians_1u1d_nofloquet": "451326", | ||
| "gaussians_1u1d": "451327", | ||
| "trapping_2u2d": "451328", | ||
| "trapping_3u3d": "451329" |
There was a problem hiding this comment.
It's a bummer these aren't permanent identifiers. I reached out to dryad help and they essentially said the only thing permanent is the dataset DOI. So a long-term fix will probably need to locate files from the DOI instead of from /stash/downloads/file_stream.
|
@rmlarose , should this be merged and you can follow-up on the bug itself? |
That seems reasonable to me. |
mrwojtek
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #165